Skip to content

Add "auto" to importModuleSpecifierPreference #34981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

andrewbranch
Copy link
Member

Fixes #29837

@mjbvz was this all you need? I looked through where this is used, and it already treats any value other than relative or non-relative as auto. I also checked that typescript-language-features already sends the string auto to the server, but maybe I’m missing something.

@typescript-bot
Copy link
Collaborator

Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

@minestarks
Copy link
Member

@jessetrinity FYI

@andrewbranch
Copy link
Member Author

@minestarks do you want me to add Jesse to the typescript-bot comment? 😁

@andrewbranch andrewbranch merged commit 4cbace7 into microsoft:master Nov 7, 2019
@andrewbranch andrewbranch deleted the bug/29837 branch November 7, 2019 22:55
@minestarks
Copy link
Member

@andrewbranch no need - I was pinging @jessetrinity as he has the VS side context on this specific setting

@jessetrinity
Copy link
Contributor

it already treats any value other than relative or non-relative as auto.

I think this wasn't the case when we added auto for quotePreference I recall having to patch up a few holes probably because this implicit auto behavior was not designed for. Is this something we will have to worry about changing down the line (will the empty string continue to be treated as auto everywhere)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add explicit "auto" importModuleSpecifier preference
6 participants