Skip to content

Fix incorrectly looking for position in call/new expression arguments when looking for indentation of type arguments #34779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2019
Merged

Fix incorrectly looking for position in call/new expression arguments when looking for indentation of type arguments #34779

merged 2 commits into from
Oct 28, 2019

Conversation

sheetalkamat
Copy link
Member

Fixes #32487

@sheetalkamat
Fix incorrectly looking for position in call/new expression arguments…
2e435ae 
… when looking for indentation of type arguments

Fixes #32487
@sheetalkamat sheetalkamat added this to the TypeScript 3.7.2 milestone Oct 28, 2019
sandersn
sandersn approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about test + punctuation nits.

@sheetalkamat @sandersn
Update src/services/formatting/smartIndenter.ts
0bb1b40 
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.7

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Oct 28, 2019
@sheetalkamat @sandersn @typescript-bot
Cherry-pick PR microsoft#34779 into release-3.7
3966d44 
Component commits:
2e435ae Fix incorrectly looking for position in call/new expression arguments when looking for indentation of type arguments Fixes microsoft#32487

0bb1b40 Update src/services/formatting/smartIndenter.ts
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@typescript-bot typescript-bot mentioned this pull request Oct 28, 2019
Merged
@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #34782 for you.

@sheetalkamat sheetalkamat merged commit cbbbcfa into master Oct 28, 2019
@sheetalkamat sheetalkamat deleted the formatting branch October 28, 2019 21:02
sheetalkamat pushed a commit that referenced this pull request Oct 28, 2019
@sandersn @sheetalkamat
Cherry-pick PR #34779 into release-3.7 (#34782)
17bd75d 
Component commits:
2e435ae Fix incorrectly looking for position in call/new expression arguments when looking for indentation of type arguments Fixes #32487

0bb1b40 Update src/services/formatting/smartIndenter.ts
Co-Authored-By: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@orta orta Awaiting requested review from orta

@amcasey amcasey Awaiting requested review from amcasey

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

@weswigham weswigham Awaiting requested review from weswigham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TypeScript 3.7.2
Development

Successfully merging this pull request may close these issues.

argumentStartsOnSameLineAsPreviousArgument crashes
3 participants
@sheetalkamat @typescript-bot @sandersn