Introduce flattened error reporting for properties, call signatures, and construct signatures #33473

weswigham · 2019-09-17T20:48:21Z

Before:

After:

…and construct signatures

weswigham · 2019-09-17T20:48:39Z

@typescript-bot test this
@typescript-bot pack this

typescript-bot · 2019-09-17T20:48:44Z

Heya @weswigham, I've started to run the extended test suite on this PR at 06908f8. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2019-09-17T20:48:44Z

Heya @weswigham, I've started to run the tarball bundle task on this PR at 06908f8. You can monitor the build here. It should now contribute to this PR's status checks.

weswigham · 2019-09-17T20:51:21Z

cc @DanielRosenwasser @RyanCavanaugh because the assign reviewers thing is stuck

DanielRosenwasser · 2019-09-17T20:58:36Z

Love it!

I'm okay with rephrasing to

The types of '{0}' are incompatible between these types.

Additionally, if there is a way to track that there are no parameters, I would cut out the ... in function calls.

typescript-bot · 2019-09-17T21:04:33Z

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/44341/artifacts?artifactName=tgz&fileId=931EC1DB45107D732E234F7803AF1DFA079F596466EA8B7A51CCFC7E7182C8A702&fileName=/typescript-3.7.0-insiders.20190917.tgz"
    }
}

and then running npm install.

weswigham · 2019-09-17T21:29:40Z

@typescript-bot test this
@typescript-bot pack this

typescript-bot · 2019-09-17T21:30:38Z

Heya @weswigham, I've started to run the extended test suite on this PR at d4fcff2. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2019-09-17T21:30:38Z

Heya @weswigham, I've started to run the tarball bundle task on this PR at d4fcff2. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2019-09-17T21:47:35Z

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/44358/artifacts?artifactName=tgz&fileId=16AD9D8D3F4E7874755206CF2ACFDB9A7CE0178F8CE287BB364592B12001C41B02&fileName=/typescript-3.7.0-insiders.20190917.tgz"
    }
}

and then running npm install.

weswigham · 2019-09-17T22:35:41Z

@DanielRosenwasser feel free to look over the RWC changes, they seem pretty OK to me~

weswigham · 2019-09-18T21:54:11Z

@typescript-bot test this
@typescript-bot pack this

@DanielRosenwasser your in-person request of skipping leading signatures is now in~

typescript-bot · 2019-09-18T21:54:15Z

Heya @weswigham, I've started to run the tarball bundle task on this PR at f5dc527. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2019-09-18T21:54:15Z

Heya @weswigham, I've started to run the extended test suite on this PR at f5dc527. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2019-09-18T22:10:43Z

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/44555/artifacts?artifactName=tgz&fileId=2DC7273910A525A7F23534E26497A6AAD73AF1DB601DC45ACBB828762A83C5E102&fileName=/typescript-3.7.0-insiders.20190918.tgz"
    }
}

and then running npm install.

weswigham · 2019-09-19T00:46:28Z

@DanielRosenwasser @sandersn whenever you get a chance, give this a review, so we can start testing it in the nightly to see what people think about it. It's fairly simple to introduce a toggle back to the old style of elaboration, if need be.

orta · 2019-09-20T20:42:35Z

This PR has a playground so you can try it out on the site.

tests/baselines/reference/extendAndImplementTheSameBaseType2.errors.txt

orta · 2019-09-20T20:50:33Z

tests/baselines/reference/interfaceWithMultipleBaseTypes.errors.txt

-      Types of property 'b' are incompatible.
-        Type 'number' is not assignable to type 'string'.
+  The types of 'x.b' are incompatible between these types.
+    Type 'number' is not assignable to type 'string'.


Does The types of 'x.b' are incompatible between these types. feels grammatically odd to you?
Maybe The types of 'x.b' are incompatible.

Though I guess it could be because it's going to mention it on the next line: in which case:

The types of 'x.b' are incompatible between these types: maybe?

The period vs colon argument could be had for every line of our pyramid of elaborations - we've settled on period right now 🤷‍♂

orta · 2019-09-20T20:51:01Z

tests/baselines/reference/invariantGenericErrorElaboration.errors.txt

-!!! related TS2728 tests/cases/compiler/invariantGenericErrorElaboration.ts:12:3: 'tag' is declared here.
+!!! error TS2322:   The types of 'constraint.constraint.constraint' are incompatible between these types.
+!!! error TS2322:     Type 'Constraint<Constraint<Constraint<Num>>>' is not assignable to type 'Constraint<Constraint<Constraint<Runtype<any>>>>'.
+!!! error TS2322:       Type 'Constraint<Runtype<any>>' is not assignable to type 'Constraint<Num>'.
    const Foo = Obj({ foo: Num })


weswigham · 2019-09-23T22:39:20Z

@DanielRosenwasser I've added the specialization for construct/call-ending chains - would you care to add more feedback/:+1:?

DanielRosenwasser · 2019-09-23T23:02:28Z

tests/baselines/reference/nestedRecursiveArraysOrObjectsError01.errors.txt

-!!! error TS2322:                           Object literal may only specify known properties, and 'jj' does not exist in type 'Style'.
+!!! error TS2322:     The types returned by 'pop()' are incompatible between these types.
+!!! error TS2322:       Type '{ foo: string; jj: number; }[][]' is not assignable to type 'Style'.
+!!! error TS2322:         Type '{ foo: string; jj: number; }[][]' is not assignable to type 'StyleArray'.


DanielRosenwasser · 2019-09-23T23:43:11Z

@typescript-bot pack this

typescript-bot · 2019-09-23T23:43:16Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 4fdabf1. You can monitor the build here. It should now contribute to this PR's status checks.

typescript-bot · 2019-09-23T23:59:29Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/45298/artifacts?artifactName=tgz&fileId=ACC28539FC46D6D95320549F7058F22881709BAB6ABC498A3F905B2F51FE20DF02&fileName=/typescript-3.7.0-insiders.20190923.tgz"
    }
}

and then running npm install.

typescript-bot · 2019-09-23T23:59:29Z

Hey @DanielRosenwasser, something went wrong when looking for the build artifact. (You can check the log here).

Zzzen · 2021-02-22T16:00:15Z

src/compiler/checker.ts

@@ -12320,7 +12320,7 @@ namespace ts {
            target: Signature,
            ignoreReturnTypes: boolean): boolean {
            return compareSignaturesRelated(source, target, CallbackCheck.None, ignoreReturnTypes, /*reportErrors*/ false,
-                /*errorReporter*/ undefined, compareTypesAssignable) !== Ternary.False;
+                /*errorReporter*/ undefined, /*errorReporter*/ undefined, compareTypesAssignable) !== Ternary.False;


should be /*incompatibleErrorReporter*/, right?

Introduce flattened error reporting for properties, call signatures, …

06908f8

…and construct signatures

Update message, specialize output for argument-less signatures

d4fcff2

weswigham assigned sandersn and DanielRosenwasser Sep 17, 2019

weswigham added 2 commits September 18, 2019 14:47

Skip leading signature incompatability flattening

4b95ba7

Merge branch 'master' into flattened-path-based-diagnostics

f5dc527

orta reviewed Sep 20, 2019

View reviewed changes

weswigham added 2 commits September 23, 2019 15:36

Add return type specialized message

8d3038a

Merge branch 'master' into flattened-path-based-diagnostics

4fdabf1

weswigham requested a review from DanielRosenwasser September 23, 2019 22:39

DanielRosenwasser reviewed Sep 23, 2019

View reviewed changes

DanielRosenwasser approved these changes Sep 23, 2019

View reviewed changes

weswigham merged commit 26caa37 into microsoft:master Sep 23, 2019

weswigham deleted the flattened-path-based-diagnostics branch September 23, 2019 23:08

orta mentioned this pull request Sep 25, 2019

Skip excess property elaborations #29760

Closed

DanielRosenwasser mentioned this pull request Sep 25, 2019

Error messages should place most relevant information first. #29759

Open

amcasey mentioned this pull request Feb 1, 2020

Performance regression in #33473 #36565

Open

sheetalkamat mentioned this pull request May 17, 2020

elidedInCompatabilityPyramid needs to be handled in tsbuildinfo file #38618

Closed

Zzzen reviewed Feb 22, 2021

View reviewed changes

gmanninglive mentioned this pull request Nov 21, 2022

Mention "return type" in the error message when return type of a function is not matching the declared type #51449

Open

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce flattened error reporting for properties, call signatures, and construct signatures #33473

Introduce flattened error reporting for properties, call signatures, and construct signatures #33473

weswigham commented Sep 17, 2019 •

edited

Loading

weswigham commented Sep 17, 2019

typescript-bot commented Sep 17, 2019 •

edited

Loading

typescript-bot commented Sep 17, 2019 •

edited

Loading

weswigham commented Sep 17, 2019

DanielRosenwasser commented Sep 17, 2019

typescript-bot commented Sep 17, 2019

weswigham commented Sep 17, 2019

typescript-bot commented Sep 17, 2019 •

edited

Loading

typescript-bot commented Sep 17, 2019 •

edited

Loading

typescript-bot commented Sep 17, 2019

weswigham commented Sep 17, 2019

weswigham commented Sep 18, 2019

typescript-bot commented Sep 18, 2019 •

edited

Loading

typescript-bot commented Sep 18, 2019 •

edited

Loading

typescript-bot commented Sep 18, 2019

weswigham commented Sep 19, 2019

orta commented Sep 20, 2019

orta Sep 20, 2019

weswigham Sep 23, 2019

orta Sep 20, 2019

weswigham commented Sep 23, 2019

DanielRosenwasser Sep 23, 2019

DanielRosenwasser commented Sep 23, 2019

typescript-bot commented Sep 23, 2019 •

edited

Loading

typescript-bot commented Sep 23, 2019

typescript-bot commented Sep 23, 2019

Zzzen Feb 22, 2021

Introduce flattened error reporting for properties, call signatures, and construct signatures #33473

Introduce flattened error reporting for properties, call signatures, and construct signatures #33473

Conversation

weswigham commented Sep 17, 2019 • edited Loading

weswigham commented Sep 17, 2019

typescript-bot commented Sep 17, 2019 • edited Loading

typescript-bot commented Sep 17, 2019 • edited Loading

weswigham commented Sep 17, 2019

DanielRosenwasser commented Sep 17, 2019

typescript-bot commented Sep 17, 2019

weswigham commented Sep 17, 2019

typescript-bot commented Sep 17, 2019 • edited Loading

typescript-bot commented Sep 17, 2019 • edited Loading

typescript-bot commented Sep 17, 2019

weswigham commented Sep 17, 2019

weswigham commented Sep 18, 2019

typescript-bot commented Sep 18, 2019 • edited Loading

typescript-bot commented Sep 18, 2019 • edited Loading

typescript-bot commented Sep 18, 2019

weswigham commented Sep 19, 2019

orta commented Sep 20, 2019

orta Sep 20, 2019

Choose a reason for hiding this comment

weswigham Sep 23, 2019

Choose a reason for hiding this comment

orta Sep 20, 2019

Choose a reason for hiding this comment

weswigham commented Sep 23, 2019

DanielRosenwasser Sep 23, 2019

Choose a reason for hiding this comment

DanielRosenwasser commented Sep 23, 2019

typescript-bot commented Sep 23, 2019 • edited Loading

typescript-bot commented Sep 23, 2019

typescript-bot commented Sep 23, 2019

Zzzen Feb 22, 2021

Choose a reason for hiding this comment

weswigham commented Sep 17, 2019 •

edited

Loading

typescript-bot commented Sep 17, 2019 •

edited

Loading

typescript-bot commented Sep 17, 2019 •

edited

Loading

typescript-bot commented Sep 17, 2019 •

edited

Loading

typescript-bot commented Sep 17, 2019 •

edited

Loading

typescript-bot commented Sep 18, 2019 •

edited

Loading

typescript-bot commented Sep 18, 2019 •

edited

Loading

typescript-bot commented Sep 23, 2019 •

edited

Loading