Hoist and distribute type parameter constraints over type parameters … #33453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when comparing against union targets when fetching union constraints
tests/cases/conformance/jsdoc/typeParameterExtendsUnionConstraintDistributed.ts
Outdated
Show resolved
Hide resolved
jack-williams
approved these changes
Sep 17, 2019
There was a problem hiding this comment.
Looks good; sorry for the quibbles. Should probably read my approval as a no-op and get @ahejlsberg to give it the OK.
|
@typescript-bot perf test this |
|
Heya @weswigham, I've started to run the perf test suite on this PR at 5c38f6a. You can monitor the build here. It should now contribute to this PR's status checks. Update: The results are in! |
|
@weswigham Here they are:Comparison Report - master..33453
System
Hosts
Scenarios
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
@ahejlsberg perf here is fine, any other comments, questions, or concerns? |
ahejlsberg
approved these changes
Sep 23, 2019
|
Just because while I feel it's probably OK, we should probably do this on relationship/inference changes for diligence (and I don't want to deal with breaks tomorrow if there are any, and would rather deal with them now): @typescript-bot run dt |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 5c38f6a. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @weswigham, I've started to run the extended test suite on this PR at 5c38f6a. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 5c38f6a. You can monitor the build here. It should now contribute to this PR's status checks. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
Excellent, DT is clean and the others are expected given the last merge date on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when comparing against union targets when fetching union constraints
Fixes #33340
The
errorbaseline changes are because I disabled the redundant error info pyramids from the distributive constraint error - I'd only really want to add them back in if I changed them to dedent like overload errors, since as-is they didn't really flow.