Skip to content

Expanding error message for incorrectly annotated functions #33165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sterlingfs
Copy link

Fixes #

Issue #32846
Updated error code to include "Did you mean..." assistance.

@DanielRosenwasser
Copy link
Member

Sorry, there may have been a misunderstanding. The original issue isn't that the existing error message is wrong. The suggestion is to add a new message and appropriately issue it under the conditions I outlined. Feel free to iterate and get back to us when you have things working, new tests have been added, and the tests pass.

By the way, as a heads up your commits don't seem to be associated with your GitHub account. While this isn't technically a problem, you might care if you want more appropriate attribution. You can either make sure your GitHub account is associated with the email address you're using for your commits, or rebase and amend your commits to fix the author name and email.

@orta
Copy link
Contributor

orta commented Nov 4, 2019

Thanks for this PR @sterlingfs - I've just merged #33171 which also addressed the same issue!

@orta orta closed this Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants