Add convert const to let #33157
Merged
Add convert const to let #33157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fuafa thanks for the PR - perfect. After reading the original issue there was a mention about:
But we don't need to handle that because that's now a separate diagnostic error (and so this fixit won't be included) |
orta
approved these changes
Sep 11, 2019
| errorCodes, | ||
| getCodeActions: context => { | ||
| const { sourceFile, span, program } = context; | ||
| const variableStatement = getVaribleStatement(sourceFile, span.start, program); |
There was a problem hiding this comment.
Suggested change
| const variableStatement = getVaribleStatement(sourceFile, span.start, program); | |
| const variableStatement = getVariableStatement(sourceFile, span.start, program); |
| fixIds: [fixId] | ||
| }); | ||
|
|
||
| function getVaribleStatement(sourceFile: SourceFile, pos: number, program: Program) { |
There was a problem hiding this comment.
Suggested change
| function getVaribleStatement(sourceFile: SourceFile, pos: number, program: Program) { | |
| function getVariableStatement(sourceFile: SourceFile, pos: number, program: Program) { |
|
Thanks @orta, sorry for the late response, typo fixed. |
|
Looks good, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22473