Mark deep indexed access comparisons as expanding

[weswigham]

Fixes #33132

Just as isDeeplyNestedType marks objects which re-nest >5 times as maybe infinitely expanding, it now also marks indexed accesses which nest >5 times in the same way. Since a deeply nested indexed access is essentially the dual of a deeply nested object type (or at least you'd need a deeply nested object to satisfy the indexing operations!), this makes sense to me.

[weswigham]

@typescript-bot test this
@typescript-bot run dt
@typescript-bot user test this

[typescript-bot]

Heya @weswigham, I've started to run the extended test suite on this PR at 7861cf4. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 7861cf4. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 7861cf4. You can monitor the build here. It should now contribute to this PR's status checks.

[weswigham]

cc @DanielRosenwasser since the referenced issue is reported as a regression in the 3.6 release~

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[weswigham]

User baselines are just today's as yet uncaptured/accepted update (just changes in upstream projects), so are clean~

[weswigham]

@typescript-bot pack this

[typescript-bot]

Heya @weswigham, I've started to run the tarball bundle task on this PR at 7861cf4. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/42509/artifacts?artifactName=tgz&fileId=A82D59BA80DA6FD462A65482799F16EB7C4F6BC924F2F7C4276F7E36EA2B62E702&fileName=/typescript-3.7.0-insiders.20190902.tgz"
    }
}

and then running npm install.

[alfaproject]

I wonder if this would also fix:

• Excessive Stack Depth from DeepPartial/RecursivePartial in 2.7.x #21592
• Excessive stack depth comparing types with TS 3.2  #29112

Edit: @weswigham I can confirm that this fixes my comment in this older issue: #29112 (comment)

[odlings]

@weswigham The insiders build fixes the issue I was having as well with

TS2321: Excessive stack depth comparing types 'LoDashExplicitWrapper<?>' and 'LoDashExplicitWrapper<?>'.

and

TS2589: Type instantiation is excessively deep and possibly infinite.

For now I've had to rollback to 3.5 as my choice is 3.6 and removing @types/lodash or 3.5 and have proper types for lodash.

[weswigham]

@typescript-bot cherry-pick this into release-3.6

[typescript-bot]

Hey @weswigham, I've opened #33249 for you.