Skip to content

Conversation

@weswigham
Copy link
Member

Resolve SymbolFlags.Type only at first in jsdoc getTypeFromTypeReference before falling back to SymbolFlags.Value.

Previously, by having both simultaneously at first, we'd find the local symbol of a merged const/type alias symbol, which only actually has value meaning applied to it. In normal codepaths, we'd skip over that to the export symbol of the same name, which has the intended type meaning.

This fixes a regression in the webpack user test. (When we started binding @enum tags a typedefs, we started having merged const/type aliases with separate export/local symbols in js (just like in TS), which were previously much harder to make)

@weswigham
Copy link
Member Author

@DanielRosenwasser pls we never merged this into 3.6 - if we are cutting a 3.6.4 at some point, this should probably be in it - this was a fix for a break in a thing webpack's js did.

@weswigham
Copy link
Member Author

Or if conversely you're not interested in this, closing the PR would be nice ❤️

@DanielRosenwasser DanielRosenwasser merged commit 50223fd into microsoft:release-3.6 Sep 24, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants