Skip to content

Only check import = reference when target is Value #32747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2019
Merged

Only check import = reference when target is Value #32747

merged 1 commit into from
Aug 6, 2019

Conversation

weswigham
Copy link
Member

Fixes #32746

This gives the import= alias expression the same guard against checking that export= and export default have.

@weswigham weswigham requested a review from sandersn August 6, 2019 23:10
@weswigham weswigham mentioned this pull request Aug 6, 2019
Merged
@weswigham weswigham merged commit abd127f into microsoft:master Aug 6, 2019
@weswigham weswigham deleted the imports-not-checked-as-values branch August 6, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dojo broken on typescript@next: Can't resolve members of merged namespace
2 participants
@weswigham @sandersn