Fix completion disappear after a property declaration with a private modifier #32726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th a private modifier
orta
approved these changes
Aug 7, 2019
|
Hi, @orta , Thanks for your review, any update on this? |
| @@ -1566,7 +1566,7 @@ namespace ts.Completions { | |||
| // If you're in an interface you don't want to repeat things from super-interface. So just stop here. | |||
| if (!isClassLike(decl)) return GlobalsSearch.Success; | |||
|
|
|||
| const classElement = contextToken.parent; | |||
| const classElement = contextToken.kind === SyntaxKind.SemicolonToken ? contextToken.parent.parent : contextToken.parent; | |||
There was a problem hiding this comment.
Is this the right fix? I get the sense that contextToken.parent.parent isn't actually a useful node, since the point of the check is simply to do nothing if you're not in the middle of the current class element.
There was a problem hiding this comment.
But the contextToken.parent.parent is a ClassDeclaration when context.kind === SyntaxKind.SemicolonToken. What I attempt to do is making the /*1*/ and /*2*/ should be in the same context.
class C {
/*1*/ // `contextToken.parent` is `ClassDeclaration`
private a = 1;
/*2*/ // `contextToken.parent` is `PropertyDeclaration`, `contextToken.parent.parent` is `ClassDeclaration`
}Do I miss something else?
sheetalkamat
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix class member completion disappear after a property declaration with a private modifier.
Fixes #30290