-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Use optional module "@microsoft/typescript-etw" for ETW logging #32612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
996e7e5
Use optional module "@microsoft/typescript-etw" for ETW logging
billti fa3e9c8
Add PerfLogger and NullLogger to simplify conditional logic
mrcrane d34cf52
Use 'noop' for NullLogger
mrcrane 5e19753
Update browser table
mrcrane 7d44a45
Remove try-finally blocks
mrcrane cca32f0
Remove more try-finally blocks
mrcrane f6fb130
Add 'readFileWorker' instead of modifying 'readFile'
mrcrane 47e77c9
Remove unnecessary 'commandSucceeded' variable
mrcrane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* @internal */ | ||
namespace ts { | ||
type PerfLogger = typeof import("@microsoft/typescript-etw"); // tslint:disable-line:no-implicit-dependencies | ||
const nullLogger: PerfLogger = { | ||
logEvent: noop, | ||
logErrEvent: noop, | ||
logPerfEvent: noop, | ||
logInfoEvent: noop, | ||
logStartCommand: noop, | ||
logStopCommand: noop, | ||
logStartUpdateProgram: noop, | ||
logStopUpdateProgram: noop, | ||
logStartUpdateGraph: noop, | ||
logStopUpdateGraph: noop, | ||
logStartResolveModule: noop, | ||
logStopResolveModule: noop, | ||
logStartParseSourceFile: noop, | ||
logStopParseSourceFile: noop, | ||
logStartReadFile: noop, | ||
logStopReadFile: noop, | ||
logStartBindFile: noop, | ||
logStopBindFile: noop, | ||
logStartScheduledOperation: noop, | ||
logStopScheduledOperation: noop, | ||
}; | ||
|
||
// Load optional module to enable Event Tracing for Windows | ||
// See https://github.com/microsoft/typescript-etw for more information | ||
let etwModule; | ||
try { | ||
// require() will throw an exception if the module is not installed | ||
// It may also return undefined if not installed properly | ||
etwModule = require("@microsoft/typescript-etw"); // tslint:disable-line:no-implicit-dependencies | ||
} | ||
catch (e) { | ||
etwModule = undefined; | ||
} | ||
|
||
/** Performance logger that will generate ETW events if possible */ | ||
export const perfLogger: PerfLogger = etwModule ? etwModule : nullLogger; | ||
|
||
perfLogger.logInfoEvent(`Starting TypeScript v${versionMajorMinor} with command line: ${JSON.stringify(process.argv)}`); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ | |
"core.ts", | ||
"debug.ts", | ||
"performance.ts", | ||
"perfLogger.ts", | ||
"semver.ts", | ||
|
||
"types.ts", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.