Skip to content

Support classification of triple-slash references #32565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2019

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Jul 25, 2019

Note: not restricted to the element and attribute names that actually bind
Bonus: classifies (many) incomplete triple-slash references

Note: not restricted to the element and attribute names that actually
bind
@amcasey
Copy link
Member Author

amcasey commented Jul 25, 2019

FYI @rakatyal

@amcasey
Copy link
Member Author

amcasey commented Jul 25, 2019

@RyanCavanaugh I'd really like to get this into 3.6, if possible.

@amcasey
Copy link
Member Author

amcasey commented Jul 29, 2019

@sheetalkamat would you mind taking a look?

Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except suggested change in regexp, change looks good

@amcasey amcasey merged commit dbe9e3d into microsoft:master Jul 29, 2019
@amcasey
Copy link
Member Author

amcasey commented Jul 29, 2019

Thanks!

@amcasey amcasey deleted the TripleSlashClassification branch July 29, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants