Set the ScriptTarget of ESNext to be 99 so it doesn't change between releases #32461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
approved these changes
Jul 17, 2019
…ween releases (and yet another module system?!)
|
@andrewbranch @uniqueiniquity This is going to need some VS side changes, too IIRC, right (and was something VS wanted to see, too)? |
|
I took a look on the VS Code and didn't find anything noting
If @uniqueiniquity is happy we can merge |
|
What would you do when ES2099 lands? |
|
@goodmind Actually, that would be ES2112, and that’ll be in a century, so we’ll cross that bridge when we get there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andrewbranch spotted a bug in the playground where ESNext wasn't being recognized, this turned out to be because this code replicates the entire set of targets in monaco-typescript, but ESNext is wrong in 3.5.1 because of
ES2019andES2020.This makes it much harder for the UI to go out of sync with the data, missing 2019/2020 isn't critical, but it's a bit more annoying for ESNext to go out of sync.