Skip to content

Make it easier to read multi-line exceptions #32421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Make it easier to read multi-line exceptions #32421

merged 1 commit into from
Jul 16, 2019

Conversation

orta
Copy link
Contributor

@orta orta commented Jul 16, 2019

This PR improves multi-line error messages from within fourslash:

  • Adds newlines
  • Bolds the titles to make it easy to see where the reported strings start/end

Screen Shot 2019-07-16 at 11 38 59 AM

andrewbranch
andrewbranch approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My eyes are happy

@orta orta merged commit 10f3063 into microsoft:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orta @sandersn @andrewbranch