Filter primitives from union when checking for mismatched excess props if nonprimitive type is present #31708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12869,6 +12869,16 @@ namespace ts { | |||
| return bestMatch; | |||
| } | |||
|
|
|||
| function filterPrimitivesIfContainsNonPrimitive(type: UnionType) { | |||
| if (some(type.types, t => !!(t.flags & TypeFlags.NonPrimitive))) { | |||
There was a problem hiding this comment.
Pretty sure there's a someTypeHasFlags or something
…s if nonprimitive type is present
weswigham
force-pushed
the
discriminate-objects-only
branch
from
a1c5b5d to
b235998
Compare
|
@typescript-bot run dt |
|
Heya @weswigham, I've started to run the extended test suite on this PR at b235998. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at b235998. You can monitor the build here. It should now contribute to this PR's status checks. |
sandersn
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31668