Add sortText depending scope of symbols #31484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
RyanCavanaugh,
andrewbranch,
rbuckton,
sandersn and
weswigham
weswigham
approved these changes
May 21, 2019
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
The linked vscode issue mentioned something about a "location bonus" - is that further refining the order of zero-ranked completions on the vscode side by using brace matching and proximity?
Member
Author
|
@weswigham yes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15024
Sorting done as per #15024 (comment)
Sorting as per #15024 (comment) is more complicated and needs more thought so for now enabling simple sorting.