Skip to content

Include only files that can be emitted into the source file directory check for composite projects #31191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2019
Merged

Include only files that can be emitted into the source file directory check for composite projects #31191

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df65a7
Add test when module resolution includes .ts file from node_modules
sheetalkamat May 1, 2019
a58fdf2
Include only files that can be emitted into the source file directory…
sheetalkamat May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Include only files that can be emitted into the source file directory… 
… check for composite projects

Fixes #31181
  • Loading branch information
@sheetalkamat
sheetalkamat committed May 1, 2019
commit a58fdf2b35f33fd7bfb29b65eafd43e920d1ab8c
6 changes: 2 additions & 4 deletions src/compiler/program.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2768,10 +2768,8 @@ namespace ts {
if (options.composite) {
const rootPaths = rootNames.map(toPath);
for (const file of files) {
// Ignore declaration files
if (file.isDeclarationFile) continue;
// Ignore json file thats from project reference
if (isJsonSourceFile(file) && getResolvedProjectReferenceToRedirect(file.fileName)) continue;
// Ignore file that is not emitted
if (!sourceFileMayBeEmitted(file, options, isSourceFileFromExternalLibrary, getResolvedProjectReferenceToRedirect)) continue;
if (rootPaths.indexOf(file.path) === -1) {
programDiagnostics.add(createCompilerDiagnostic(Diagnostics.File_0_is_not_in_project_file_list_Projects_must_list_all_files_or_use_an_include_pattern, file.fileName));
}
Expand Down
18 changes: 0 additions & 18 deletions tests/baselines/reference/compositeWithNodeModulesSourceFile.errors.txt
View file
Open in desktop

This file was deleted.