Fall back from globalReadonlyArrayType to globalArrayType when transpiling
#30734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
approved these changes
Apr 4, 2019
sandersn
approved these changes
Apr 4, 2019
|
@sandersn I wasn't able to get it to repro with a compiler test, but in hindsight there was probably an option that does trigger it. I think I tried |
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Apr 7, 2019
Fix at microsoft/TypeScript#30734 for an issue with TypeScript 3.4.x and use of `readonly T[]`, which causes webpack to report the following error: ``` TypeError: Cannot read property 'instantiations' of undefined ```
sqs
added a commit
to sourcegraph/sourcegraph-public-snapshot
that referenced
this pull request
Apr 7, 2019
* upgrade to TypeScript 3.5.0 (dev) to fix `readonly` bug Fix at microsoft/TypeScript#30734 for an issue with TypeScript 3.4.x and use of `readonly T[]`, which causes webpack to report the following error: ``` TypeError: Cannot read property 'instantiations' of undefined ``` * remove use of toString method on generic type parameter (TS 3.5 rejects it) ``` ../shared/src/util/memoizeObservable.ts:37:58 - error TS2339: Property 'toString' does not exist on type 'P'. const key = resolver ? resolver(params) : params.toString() ```
andrewbranch
added a commit
to andrewbranch/TypeScript
that referenced
this pull request
Apr 12, 2019
Fall back from `globalReadonlyArrayType` to `globalArrayType` when transpiling
RyanCavanaugh
pushed a commit
that referenced
this pull request
Apr 12, 2019
Fall back from `globalReadonlyArrayType` to `globalArrayType` when transpiling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax like
([''] as const).forEachorlet x: readonly string[]implicitly referencesReadonlyArraywhich isn't included when transpiling, so fall back to referencing the global Array type instead.Fixes #30664