Refactor narrow type by instance of #3064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else if (rightType.flags & TypeFlags.Anonymous) { | ||
| constructSignatures = getSignaturesOfType(rightType, SignatureKind.Construct); | ||
| } | ||
| if (constructSignatures && constructSignatures.length) { |
There was a problem hiding this comment.
Put an extra newline here so it looks separate from the prior two conditions
|
👍 |
mhegazy
added a commit
that referenced
this pull request
May 7, 2015
Refactor narrow type by instance of
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor narrowTypeByInstanceof to be more uniform for its two branches (prototype and construct signature return types), also fixed an issue we ran into in real world code. Added a regression test for it.