Harness now reports a difference in line endings when comparing baselines #3030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,9 +1,9 @@ | |||
| //// [newLineFlagWithCRLF.ts] | |||
| //// [newLineFlagWithCRLF.ts] | |||
| var x=1; | |||
There was a problem hiding this comment.
this file should be line ending sensitive.
There was a problem hiding this comment.
@mhegazy I'm not sure what you mean.
There was a problem hiding this comment.
sorry missed the change in name of the variable.. can you also make sure that these files are never normalized.. or if you are deleting the code, then we are fine :)
There was a problem hiding this comment.
I plan to delete the code.
There was a problem hiding this comment.
I've now deleted the code.
|
👍 |
1 similar comment
|
👍 |
JsonFreeman
added a commit
that referenced
this pull request
May 5, 2015
Harness now reports a difference in line endings when comparing baselines
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.