Add explicit "auto" quotePreference #29785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
approved these changes
Feb 6, 2019
minestarks
added a commit
to minestarks/TypeScript
that referenced
this pull request
Feb 6, 2019
…eference Add explicit "auto" quotePreference
amcasey
reviewed
Feb 7, 2019
| switch (preferences.quotePreference) { | ||
| case undefined: | ||
| switch (quotePreference) { | ||
| // TODO use getQuotePreference to infer the actual quote style. |
There was a problem hiding this comment.
No, it may be a good idea though
There was a problem hiding this comment.
Probably tag the one above with the same ID.
|
Merged a bit prematurely, still testing, please feel free to keep reviewing |
|
I would have guessed that this feature had reasonably good test coverage, so it should be straightforward to copy/modify one to cover |
|
Is VS going to start sending |
|
@amcasey yes there will be a VS side change incoming to send |
This was referenced Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29762
Today, VS passes
""forUserPreferences.quotePreferenceto imply "infer from existing imports". This was causing an exception to be thrown fromcreateCompletionEntry/quotewhen wrapping some properties in quotes.This PR accomplishes two things
""more gracefully so the exception is avoidedautooption for this preference.@jessetrinity wrote this.
FYI @mjbvz for VS Code
@RyanCavanaugh we'd like to take this into 3.3.2 as a fix for that exception.