Fix issues related to circular mapped array and tuple types #29740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #27911 and implements a less aggressive and more robust scheme for detecting infinitely circular mapped types applied to arrays and tuples. We now allow type instantiation to run up against the already existing type instantiation depth limiter (with a limit of 50) and then propagate the error type up instead of leaving it at the bottom of a 50 level deep type instantiation.
The PR also fixes an issue of us not detecting a homomorphic mapped type nested in a conditional type as reported in #29702.
Fixes #29442.
Fixes #29577.
Fixes #29702.