avoid add missing member in declaration file #29493
Conversation
src/compiler/utilities.ts
Outdated
| @@ -1698,6 +1698,10 @@ namespace ts { | |||
| return !!node && !!(node.flags & NodeFlags.JSDoc); | |||
| } | |||
|
|
|||
| export function isInDeclarationFile(node: Node | undefined): boolean { | |||
There was a problem hiding this comment.
This isn't a correct check. Ambient nodes can occur inside non-declaration files, e.g. in
declare namespace X {
}blocks
There was a problem hiding this comment.
Probably worth remembering that the original issue is specifically about the stdlib files (which generally shouldn't be editable), and not all .d.ts files. Adding more props to declarations within your own project are fine - but adding props to a stdlib or node_modules sourced declaration is prooooobably wrong. Well, it's wrong unless the addition is done by making an augmentation in the current file 😛
There was a problem hiding this comment.
Probably only check file in node_modules?
There was a problem hiding this comment.
We should really apply a concrete notion of where a .d.ts file "came from" - lib, upstream composite project, node_modules/types, or a local "hand-authored" .d.ts file, only the last of which is a valid rename target
There was a problem hiding this comment.
isSourceFileFromExternalLibrary is that not good indication?
There was a problem hiding this comment.
Sounds like exactly what we want 😃
Kingwl
force-pushed
the
avoid-quickfix-for-declaration-file
branch
from
47f49a8 to
53b7e9d
Compare
Kingwl
force-pushed
the
avoid-quickfix-for-declaration-file
branch
from
53b7e9d to
bf42f5b
Compare
Fixes #29482