Skip to content

Parse an object literal property as shorthand unless followed by '(' or ':' #28121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Oct 26, 2018
Merged

Parse an object literal property as shorthand unless followed by '(' or ':' #28121

1 commit merged into from
Oct 26, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2018

Fixes #28107

Previously at { x y: 3 } we would try parsing y as the initializer of x. Now we will make x a shorthand property, preserving y: 3 as its own property.
Updates many baselines but they were all error cases already.

@zafarmandor786
Copy link

Thanks

1 similar comment
@zafarmandor786
Copy link

Thanks

@ghost ghost merged commit 36dfd77 into master Oct 26, 2018
@ghost ghost deleted the completionsAtIncompleteObjectLiteralProperty branch October 26, 2018 22:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zafarmandor786 @sheetalkamat