-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Update CI #28082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #28082
Conversation
Currently stable and 10 are the same node version. |
@j-oliveras Check this out: https://futurestud.io/tutorials/node-js-why-you-should-add-node-in-your-travis-config |
They just released node 11 as stable. |
https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V11.md#11.0.0 |
Travis is really only tolerable running 3 versions since we only get about 5 concurrent builds. That's why we've just been running latest stable and usually two older LTS. |
@weswigham 10 is now LTS. Should I drop 6? |
If 6 is still LTS, I think 11/10/6 gets us the best coverage for now, and then we can move 6 to 8 once 6 falls out of LTS. |
@weswigham Got it. I dropped node 8. |
I'll merge after master passes tests with node 11 (from #28108) |
Summary
This PR
stable
withnode
, is node11
currently10
8
Details
Node.js Release
Specifying Node.js versions
Why Adding “node”?