Skip to content

Fix checking for type parameter visibility when merged with a parameter #27444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

weswigham
Copy link
Member

Fixes #25672

A type parameter merged with a parameter has both type and value meanings, and both the Type and the Value masks contain some of the same meanings (Class, Enum, EnumMember and Assignment), so comparing a target meaning (and not a flags member) against just one of them almost always yields true. We really only want to limit the scope of the parameter meanings of the symbol to the function body, so we need to ensure that the meaning we're looking for is really just the value meanings we actually care about (in this case, FunctionScopedVariable).

@weswigham weswigham changed the title Exclude the overlap between Type and Value when checking for parameter visibility Fix checking for type parameter visibility when merged with a parameter Sep 28, 2018
@weswigham weswigham merged commit 1e55d65 into microsoft:master Oct 2, 2018
@weswigham weswigham deleted the type-parameters-and-parameters branch October 2, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants