Update GDPR annotations #27242
Update GDPR annotations #27242
Conversation
sandersn
commented
Sep 20, 2018
sandersn
commented
- Use TypeScriptCommonProperties -- after moving Typescript to the extension extract step in https://github.com/Microsoft/vscode-gdpr-tooling/pull/4, TypeScriptCommonProperties is properly resolved.
- Add projectInfo. Based on what @kieferrm said, I think that EndUserPseudonymizedInformation is correct for projectInfo.
| @@ -46,6 +46,8 @@ namespace ts.server { | |||
|
|
|||
| /* __GDPR__ | |||
| "projectInfo" : { | |||
| "${include}": ["${TypeScriptCommonProperties}"], | |||
There was a problem hiding this comment.
Did we figure out how this interacts with version below?
There was a problem hiding this comment.
The included one overrides the local one. I think I'll leave it in since TypeScriptCommonProperties could (in theory) also remove properties over time as well as add more.
There was a problem hiding this comment.
Weird that the local one wouldn't win, but I agree that keeping both makes sense.
src/server/editorServices.ts
Outdated
| @@ -46,6 +46,8 @@ namespace ts.server { | |||
|
|
|||
| /* __GDPR__ | |||
| "projectInfo" : { | |||
| "${include}": ["${TypeScriptCommonProperties}"], | |||
| "projectInfo": { classification: "EndUserPseudonymizedInformation", purpose: "FeatureInsight" }, | |||
There was a problem hiding this comment.
I believe an endpoint is mandatory for EUPI (i.e. you're probably missing a property).
There was a problem hiding this comment.
That's not what the documentation says -- it says that 'none' is right for almost everything except a few common properties.
1. Add quotes where missing. 2. Fix name, which was projectInfo by mistake. 3. Add an endpoint of "ProjectId".
|
Well, the endpoint "ProjectId" doesn't make the gdpr tool fall over, so I'll check with @kieferrm about using it. |
|
Actually, ProjectId refers to VS project ids not VS Code ids, I believe, so I'm not sure it makes sense here. |
| @@ -46,6 +46,8 @@ namespace ts.server { | |||
|
|
|||
| /* __GDPR__ | |||
| "projectInfo" : { | |||
| "${include}": ["${TypeScriptCommonProperties}"], | |||
There was a problem hiding this comment.
Weird that the local one wouldn't win, but I agree that keeping both makes sense.
