Skip to content

getEditsForFileRename: Don't resolve to a.js when a.ts is moved #27081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Sep 13, 2018

Conversation

ghost
Copy link

@ghost ghost commented Sep 13, 2018

Fixes an issue in projects where a.ts and compiled to a.js right next to it -- we would resolve to a.js and not update the import. Now we will always look for a moved file before searching through non-moved files.
(Note the only reason we search through non-moved files is that the moved file's own imports can resolve to non-moved files and need updating if the moved file changed directories.)

@ghost ghost requested a review from sheetalkamat September 13, 2018 22:42
@ghost ghost merged commit ee7d0e2 into master Sep 13, 2018
@ghost ghost deleted the getEditsForFileRename_notAffectedByJsFile branch September 13, 2018 22:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant