Skip to content

typo: missing word: "to" #27079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2018
Merged

typo: missing word: "to" #27079

merged 1 commit into from
Sep 13, 2018

Conversation

bhamail
Copy link
Contributor

@bhamail bhamail commented Sep 13, 2018

Change:
...a resolve callback used resolve the promise...
to:
...a resolve callback used to resolve the promise...

This PR suggested in prior PR on generated files: #27075

Still not sure why that newline is being injected by the GitHub editor UI. Then again, maybe the source files should have terminating newlines? (let the debate ensue). ;)

Fixes #

Change:
...a resolve callback used resolve the promise...
to: 
...a resolve callback used to resolve the promise...

This PR suggested from: microsoft#27075
@bhamail bhamail mentioned this pull request Sep 13, 2018
@sandersn
Copy link
Member

Pretty sure POSIX says files are supposed to be terminated by a newline because lines are terminated, not separated by a newline. That's probably why the editor injects it.

@sandersn sandersn merged commit 2b0e9e6 into microsoft:master Sep 13, 2018
@sandersn
Copy link
Member

Thanks for the fix @bhamail !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants