fix list emitted file with emitDeclarationOnly options - #27045
Closed
Wenlu Wang (Kingwl) wants to merge 4 commits into
Closed
fix list emitted file with emitDeclarationOnly options#27045Wenlu Wang (Kingwl) wants to merge 4 commits into
Wenlu Wang (Kingwl) wants to merge 4 commits into
Conversation
Sheetal Nandi (sheetalkamat)
requested changes
Sep 12, 2018
| emittedFilesList.push(bundleInfoPath); | ||
| } | ||
| } | ||
| else if (emittedFilesList && compilerOptions.emitDeclarationOnly && declarationFilePath) { |
There was a problem hiding this comment.
I don't this this is right fix. We should set emitSkipped correctly instead (because emitDeclarationOnly does not skip emit by emitting only .d.ts)
Wenlu Wang (Kingwl)
force-pushed
the
fix_list_emitted_file
branch
from
September 13, 2018 07:33
f191252 to
66028f7
Compare
Contributor
Author
|
i'm not sure change the order of the list is correct |
Wenlu Wang (Kingwl)
force-pushed
the
fix_list_emitted_file
branch
from
September 13, 2018 08:40
66028f7 to
d577e78
Compare
| } | ||
| if (declarationFilePath) { | ||
| emittedFilesList.push(declarationFilePath); | ||
| } |
There was a problem hiding this comment.
Thank you. This looks good. While you are at it can you please also add
if(declarationMapPath) {
emittedFilesList.push(declarationMapPath);
}
Sheetal Nandi (sheetalkamat)
approved these changes
Sep 13, 2018
Sheetal Nandi (sheetalkamat)
approved these changes
Oct 8, 2018
| const fs = projFs.shadow(); | ||
| const host = new fakes.SolutionBuilderHost(fs); | ||
| const builder = createSolutionBuilder(host, ["/src/tests"], { listEmittedFiles: true, declaration: true, emitDeclarationOnly: true }); | ||
| builder.buildAllProjects(); |
There was a problem hiding this comment.
I think you also need to update this and test case above to include anotherModule.d.ts.map, index.d.ts.map
Member
|
Closing this in favor of #27715 which inline with what we would want to do if we want to skip js emit for some files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27009
have no test🤷🏻♂️