Skip to content

Invert gutter instead of setting colors #26983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2018
Merged

Invert gutter instead of setting colors #26983

merged 1 commit into from
Sep 11, 2018

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Sep 8, 2018 •
edited
Loading

Fixes #26850

  • There is an associated issue that is labeled
    'Bug' or 'help wanted' or is in the Community milestone
  • Code is up-to-date with the master branch
  • You've successfully run jake runtests locally
  • You've signed the CLA
  • There are new or updated unit tests validating the change

Before

Light+

screen shot 2018-09-08 at 1 09 31 pm

Dark+

screen shot 2018-09-08 at 1 29 04 pm

After

Light+

screen shot 2018-09-08 at 1 11 36 pm

Dark+

screen shot 2018-09-08 at 1 28 47 pm

@Tyriar
Copy link
Member Author

Tyriar commented Sep 8, 2018

Looks like the CI failure is a flake or config error (no npm i -g jake?)

@sheetalkamat sheetalkamat merged commit e1daa47 into microsoft:master Sep 11, 2018
@Tyriar Tyriar deleted the 26850_invert_gutter branch September 11, 2018 18:38
@DanielRosenwasser
Copy link
Member

Thanks Daniel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @DanielRosenwasser @sheetalkamat