Get symbol at location for class expressions/keywords #26636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it did not.
ghost
approved these changes
Aug 23, 2018
mheiber
pushed a commit
to mheiber/TypeScript
that referenced
this pull request
Aug 23, 2018
* getSymbolAtLocation understands class expressions Previously it did not. * Update baselines
mheiber
pushed a commit
to mheiber/TypeScript
that referenced
this pull request
Aug 23, 2018
* getSymbolAtLocation understands class expressions Previously it did not. * Update baselines
joeywatts
pushed a commit
to joeywatts/TypeScript
that referenced
this pull request
Sep 25, 2018
* getSymbolAtLocation understands class expressions Previously it did not. * Update baselines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
getSymbolAtLocationdidn't do anything forclasskeywords. It did for function keywords (see the fourslash testquickInfoClassFunctionKeyword), so it makes sense for class keywords too, I think.Might fix #26511, although I think there @ajafff wants getSymbolAtLocation to work for ClassExpression nodes, and those can't be indicated directly from the source text.