Skip to content

Parse class in strict mode #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 4, 2015
Merged

Parse class in strict mode #2596

merged 6 commits into from
Apr 4, 2015

Conversation

@yuit
Copy link
Contributor

@yuit yuit commented Apr 2, 2015

Address #2465

@mhegazy
Copy link
Contributor

mhegazy commented Apr 2, 2015

Can you file an issue for parsing modules in strict mode as well.

mhegazy
mhegazy reviewed Apr 2, 2015
View reviewed changes
tests/baselines/reference/collisionArgumentsClassConstructor.errors.txt Outdated
Copy link
Contributor

@mhegazy mhegazy Apr 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the error message a bit better when inside a class.. it is just a hard change for users migrating.

Yui T added 4 commits April 2, 2015 17:42
Address code review: have more explicit error
aef37f1
Merge branch 'master' into parseClassInStrictMode
742f65c 
Conflicts:
	src/compiler/diagnosticInformationMap.generated.ts
	src/compiler/diagnosticMessages.json
Update baseline
4824e96
Address code review
09d037f
yuit added a commit that referenced this pull request Apr 4, 2015
@yuit
Merge pull request #2596 from Microsoft/parseClassInStrictMode
5e7343f 
Parse class in strict mode
@yuit yuit merged commit 5e7343f into master Apr 4, 2015
@yuit yuit deleted the parseClassInStrictMode branch April 4, 2015 01:59
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Apr 4, 2015

I'm not big on this error message; maybe we can do something with a diagnostic message chain like

Cannot name an identifier 'arguments' in strict mode.
    Class bodies are parsed in strict mode.

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented Apr 4, 2015

Actually something closer to @yuit's original error:

Invalid use of '{0}' because class bodies are parsed in strict mode.

or

Cannot name an identifier '{0}' because class bodies are parsed in strict mode.

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yuit @mhegazy @DanielRosenwasser @CyrusNajmabadi @RyanCavanaugh @msftclas