Consistently use ScriptInfo for converting positions to Locations #25623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
approved these changes
Jul 13, 2018
|
Waiting for review from @DanielRosenwasser |
sheetalkamat
requested changes
Jul 13, 2018
src/server/session.ts
Outdated
| private mapTextChangeToCodeEditUsingScriptInfoOrConfigFile(change: FileTextChanges): protocol.FileCodeEdits { | ||
| return mapTextChangesToCodeEditsUsingScriptInfoOrConfig(change, this.projectService.getScriptInfoOrConfig(this.normalizePath(change.fileName))); | ||
| private mapTextChangeToCodeEdit(change: FileTextChanges): protocol.FileCodeEdits { | ||
| return mapTextChangesToCodeEdits(change, this.projectService.getScriptInfoOrConfig(this.normalizePath(change.fileName))); |
There was a problem hiding this comment.
I dont think you want to convert the fileName to normalizePath.. Instead you want to pass it as is to the getScriptOfConfig and there you will do the right thing.
src/server/session.ts
Outdated
| private mapTextChangeToCodeEditUsingScriptInfoOrConfigFile(change: FileTextChanges): protocol.FileCodeEdits { | ||
| return mapTextChangesToCodeEditsUsingScriptInfoOrConfig(change, this.projectService.getScriptInfoOrConfig(this.normalizePath(change.fileName))); | ||
| private mapTextChangeToCodeEdit(change: FileTextChanges): protocol.FileCodeEdits { | ||
| return mapTextChangesToCodeEdits(change, this.projectService.getScriptInfoOrConfig(this.normalizePath(change.fileName))); |
There was a problem hiding this comment.
Add test for the scenario @DanielRosenwasser was seeing where in the buffer was buffer with dynamic file name
ghost
force-pushed
the
scriptInfoForLocations
branch
from
be082ac to
e192c2c
Compare
ghost
mentioned this pull request
|
@Andy-MS can you please port this to release-3.0 as well. |
ghost
pushed a commit
that referenced
this pull request
Jul 18, 2018
…5623) * Consistently use ScriptInfo for converting positions to Locations * Code review
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DanielRosenwasser Could you check if this fixes #25560 ?
Should fix #24857 too