Link back to likely declarations in "did you mean...?" error messages #25477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhegazy
reviewed
Jul 6, 2018
| return result; | ||
| } | ||
|
|
||
| function getSuggestionForNonexistentSymbol(location: Node | undefined, outerName: __String, meaning: SymbolFlags): string | undefined { |
There was a problem hiding this comment.
we should have made these all internal :(
There was a problem hiding this comment.
Yeah. 😡
We still can?
mhegazy
approved these changes
Jul 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request provides a related span on the declaration we're suggesting in our "did you mean...?" error messages.
It currently doesn't handle union/intersection properties, or some corrections like with instance/static properties. So I guess it's a work in progress depending on how deep we want to go.
Fixes #25031
Also:
Fixes #25473
Fixes #25475