addMethodDeclaration: add after quickfix location if possible

[vpukhanov]

Fixes #22674

Declare method quickfix/codeaction now inserts method after the current location.

Current behavior:

class Foo {
    b(): any {
        throw new Error("Method not implemented.");
    }
    a() {
        this.b()
    }
}

Changed behavior:

class Foo {
    a() {
        this.b()
    }
    b(): any {
        throw new Error("Method not implemented.");
    }
}

The old behavior is preserved if quickfix is applied outside of the class. In that case the method is inserted at the start of the class.

class Foo {
    b(): any {
        throw new Error("Method not implemented.");
    }
    f() {

    }
}

// quickfix is called inside of another class
class Bar {
    b() {
        let foo = new Foo();
        foo.b();
    }
}

// or outside of the class
let fooer = new Foo();
fooer.b();

This is my first contribution to TypeScript, so please review carefully :)

[vpukhanov]

The tests pass locally, but none of the VSTS or Travis builds succeeded. Is that something to worry about or is this just a temporary issue with the build process?

[mhegazy]

how about:

function getContainingMethodDeclaration(node: Node, classDeclaration:ClassLikeDeclaration) {
    const method = getAncestor(node, SyntaxKind.MethodDeclaration);
    return method && method.parent === classDeclaration ? method : undefined;
}

[mhegazy]

i would also inline these in the caller.

[mhegazy]

nit, containingMethodDeclaration

[vpukhanov]

Thank you so much @mhegazy! Implemented all of your suggestions, this is a much cleaner code.

[mhegazy]

thanks!