Skip to content

Value decorators #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 36 commits into from
Closed

Value decorators #2386

wants to merge 36 commits into from

Conversation

rbuckton
Copy link
Contributor

Adds initial support for decorators.

rbuckton and others added 30 commits February 5, 2015 16:16
@rbuckton
Initial parse and emit for decorators on declarations, class elements…
b42b44e 
…, and parameters
@rbuckton
Add emit for decorators on parameters
ff73e97
@rbuckton
Fixed incorrect emit for parameter on setter
346f167
@rbuckton
Fixed whitespace
ec6acdf
@rbuckton
Always return the cache for computed property names and descriptors
8de67f3
@rbuckton
Added parser context and lookahead to avoid parsing a decorator for a…
e4d9b74 
… computed property name as element access.
@rbuckton
Initial type-check for decorators
b25529b
@rbuckton
Updated emit and typecheck for decorators
d7fe783
@rbuckton
Fixed formatting for decorators
f6d3a5f
@rbuckton
Added global resolution for symbols and types for decorators
05fc881
@rbuckton
Added initial support for built-in decorators: @type, @paramtypes, an…
677d710 
…d @returntype
@rbuckton
Merge branch 'master' into decorators
9862c87
@rbuckton
Additional type check for decorators, added @decorator
8c3c759
@rbuckton
initial pass for @conditional
86dbd50
@rbuckton
Fixed typo in CompilerOptions
07f6d4d
@rbuckton
Clean up for @conditional and @obsolete, added support for DecoratorT…
e71d3df 
…argets enum
@rbuckton
cleanup of DecoratorFlags, scaffolding to check compatibility with Me…
5251ce2 
…mberDecoratorFunction.
@rbuckton
Fixed wrong return value when ambient decorator argument list is empty.
b10ac56
@rbuckton
elide ExpressionStatement when it's expression is removed by @conditi…
fd96654 
…onal.
@rbuckton
Updated @type, @paramtypes, and @returntype to only use explicit type…
10e8f93 
… annotations. Removed extraneous/unused code
@rbuckton
Merge branch 'master' into decorators
d3525d8
@rbuckton
Updated baselines and cleanup of decorator checks.
ebdf444
@rbuckton
Added type-check for decorators and member decorators to error on cha…
a7b8ac3 
…nging to an incompatible type.
@rbuckton
Added caching for built-in decorator checks on SymbolLinks.
a5a2211
@rbuckton
Updated baselines
622eb92
@rbuckton
Add fallback for decorator checks when using mismatched lib.d.ts
0f8093a
@rbuckton
Fix for parameter decorators reported as invalid
2173a9b
@rbuckton
Fix for isDeclarationStart with unexpected modifier before decorator
0e20b97
@rbuckton
Test fixes.
590674f
@rbuckton
Removed ambient decorator functionality, some cleanup and tests
b705a12
@rbuckton rbuckton closed this Mar 17, 2015
@rbuckton rbuckton deleted the valueDecorators branch March 17, 2015 21:25
@rbuckton rbuckton restored the valueDecorators branch March 17, 2015 21:31
@rbuckton rbuckton deleted the valueDecorators branch March 17, 2015 21:31
@mhegazy
Copy link
Contributor

mhegazy commented Mar 17, 2015

PR moved to #2399.

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rbuckton @mhegazy @mihailik @msftclas