Find-all-references: Don't crash on 'typeof import' #23448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
weswigham
reviewed
Apr 16, 2018
src/compiler/types.ts
Outdated
| @@ -3187,13 +3187,14 @@ namespace ts { | |||
| export type AnyImportSyntax = ImportDeclaration | ImportEqualsDeclaration; | |||
|
|
|||
| /* @internal */ | |||
| export type AnyImportOrReExport = AnyImportSyntax | ExportDeclaration; | |||
| export type AnyImportOrReExport = AnyImportSyntax | ExportDeclaration | ImportTypeNode; | |||
There was a problem hiding this comment.
IIRC, this is used as a shorthand in the definition of some other aliases which should not handle import type nodes (due to only handling statements) - those probably should be changed to not use it, since the type guards used with those aliases don't check for nonstatements.
There was a problem hiding this comment.
Yeah, isAnyImportOrReExport's return type isn't accurate with this change. (The other uses within the core layer aren't so bad because they're used in a union alongside ImportTypeNode anyway)
sheetalkamat
approved these changes
Apr 17, 2018
|
@weswigham Could you update your review? |
weswigham
approved these changes
Apr 17, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was crashing because we expected a member of
SourceFile.importsto be one of only a few kinds.