Update user tests with improved lib settings #23238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
approved these changes
Apr 6, 2018
mhegazy
reviewed
Apr 6, 2018
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(116,18): error TS2345: Argument of type 'Timer | null' is not assignable to parameter of type 'number | undefined'. | ||
| Type 'null' is not assignable to type 'number | undefined'. | ||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(129,18): error TS2345: Argument of type 'Timer | null' is not assignable to parameter of type 'number | undefined'. | ||
| Type 'null' is not assignable to type 'number | undefined'. | ||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(147,18): error TS2345: Argument of type 'Timer | null' is not assignable to parameter of type 'number | undefined'. | ||
| Type 'null' is not assignable to type 'number | undefined'. | ||
| node_modules/enhanced-resolve/lib/CachedInputFileSystem.js(154,19): error TS2569: Type 'IterableIterator<any>' is not an array type or a string type. Use compiler option '--downlevelIteration' to allow iterating of iterators. |
There was a problem hiding this comment.
maybe add -downlevelIteration as well.
There was a problem hiding this comment.
why not target es6/esnext? There is no emit here.
mhegazy
reviewed
Apr 6, 2018
| node_modules/enhanced-resolve/lib/ParsePlugin.js(17,23): error TS2339: Property 'assign' does not exist on type 'ObjectConstructor'. | ||
| node_modules/enhanced-resolve/lib/Resolver.js(19,26): error TS2304: Cannot find name 'Map'. | ||
| node_modules/enhanced-resolve/lib/Resolver.js(160,29): error TS2304: Cannot find name 'Set'. | ||
| node_modules/enhanced-resolve/lib/Resolver.js(162,17): error TS2339: Property 'push' does not exist on type 'Set<any>'. |
There was a problem hiding this comment.
fun stuff.. used to be an array, now a set, just put a push method on it, and everybody is happy.
mhegazy
reviewed
Apr 6, 2018
| @@ -1,15 +1,15 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| node_modules/npm/bin/npm-cli.js(6,13): error TS2551: Property 'echo' does not exist on type '{ Echo(s: any): void; StdErr: TextStreamWriter; StdOut: TextStreamWriter; Arguments: { length: nu...'. Did you mean 'Echo'? | |||
| node_modules/npm/bin/npm-cli.js(13,13): error TS2551: Property 'quit' does not exist on type '{ Echo(s: any): void; StdErr: TextStreamWriter; StdOut: TextStreamWriter; Arguments: { length: nu...'. Did you mean 'Quit'? | |||
| node_modules/npm/bin/npm-cli.js(5,14): error TS2304: Cannot find name 'WScript'. | |||
There was a problem hiding this comment.
also add to --lib scripthost
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib: ["esnext", "dom"]module.exports=andmodule.exports.property=in the same file.