Support goto-definition for index signatures #23220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
goToDefinitionIndexSignature
branch
from
711cfc2 to
a716faa
Compare
DanielRosenwasser
requested changes
Apr 6, 2018
src/services/goToDefinition.ts
Outdated
| const type = checker.getTypeAtLocation(node.parent.expression); | ||
| if (!type.getStringIndexType()) return undefined; | ||
| const result: DefinitionInfo[] = []; | ||
| for (const root of getRootSymbolsOfType(type, checker)) { |
There was a problem hiding this comment.
Can't you use getIndexInfoOfType?
mhegazy
approved these changes
Apr 6, 2018
|
@DanielRosenwasser Good to go? |
sheetalkamat
reviewed
Apr 6, 2018
src/services/goToDefinition.ts
Outdated
| const type = checker.getTypeAtLocation(node.parent.expression); | ||
| return mapDefined(type.isUnionOrIntersection() ? type.types : [type], nonUnionType => { | ||
| const info = checker.getIndexInfoOfType(nonUnionType, IndexKind.String); | ||
| return info && createDefinitionFromSignatureDeclaration(checker, info.declaration); |
There was a problem hiding this comment.
info.declaration can be undefined, so you need to check that as well.
sheetalkamat
approved these changes
Apr 6, 2018
DanielRosenwasser
approved these changes
Apr 9, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23212