Skip to content

Path completions for import types #23082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2018

Conversation

weswigham
Copy link
Member

Fixes one of the points brought up in this comment.

@weswigham weswigham requested review from mhegazy, sheetalkamat and a user April 2, 2018 19:19
@@ -201,14 +201,6 @@ declare namespace FourSlashInterface {
assertHasRanges(ranges: Range[]): void;
caretAtMarker(markerName?: string): void;
completionsAt(markerName: string | ReadonlyArray<string>, completions: ReadonlyArray<string | { name: string, insertText?: string, replacementSpan?: Range }>, options?: CompletionsAtOptions): void;
completionsAndDetailsAt(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this from the fourslash .d.ts because I tried to use it then discovered that it doesn't exist at runtime - the verify class doesn't have this member (any more?).

//// }
////}
// @Filename: /node_modules/package/index.ts
////export namespace Foo {
Copy link

@ghost ghost Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path completions shouldn't even need to read the file, so this could just be ////file content not read

@weswigham weswigham merged commit fd553df into microsoft:master Apr 2, 2018
@weswigham weswigham deleted the import-types-ls branch April 2, 2018 23:15
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants