CSharp Style Object Literal Formatting

[aozgaa]

Fixes a vsfeedback issue: https://developercommunity.visualstudio.com/content/problem/217993/javascript-braces-incorrectly-alignedindented.html

Today, we format object literals that star on their own line like this

var clear =
    {
        outerKey:
            {
                innerKey: 1
            }
    };

the user asked that we instead format them like this

var clear =
{
    outerKey:
    {
        innerKey: 1
    }
};

which is what this PR implements.

One subtlety is in the handling of formatting a synthesized object literal node. Since it is synthesized, the node doesn't exist within a sourcefile. So, we cannot reference the node's sourcefile to figure out if it is multiline (where the non-indentation of the open curly kicks in). Today, all object literals are synthesized to be single line, so the multi-line check just defers to the default indentation.

This reasoning coudld be made more explicit as a comment within the smart indenter if a reviewer considers it worthwhile.

[ghost]

This was meant to describe the if (sourceFile)? I think it should go on the same line then.

[ghost]

Could use an isSingleLineNode(Node, SourceFile) helper

[amcasey]

Did any of the tests cover the case where this is false?

[aozgaa]

I've added test where the startline is the same as the endline, despite leading trivia making the object-literal child's pos inappropriate to refer to.

[amcasey]

Do we have any back compat concerns?

[DanielRosenwasser]

I have back compat concerns. I'd sort of rather this be an option for users than the default. At the time of writing, the suggestion has 0 upvotes, so I have no idea who would want this feature vs. who would be very unhappy with this feature.

[mhegazy]

pass in the sourceFile instead of walking up on every node.

[mhegazy]

and keep child TextRangeWithKind

[mhegazy]

We do need an option to control this formatting change. does not matter much which is the default really, but a way to opt out/in into this

[aozgaa]

@mhegazy @DanielRosenwasser To clarify, this doesn't actually put object literals on their own line. All it does is change the indentation of object literals that already started on their own line and are multi-line.

Should we still offer a switch?

[mhegazy]

Well, we need to have formatting working correctly as well... I am assuming ppl want to format the file and have the formatting sticks..

it would be weird to have something like:

var x =
{
    a: 0,
    b: "",
    |
}

work, but then you add a semi-colon after the } and the whole thing moves 4 spaces to the right.

[ghost]

My previous comment's marked outdated since this code was moved: This could use an isSingleLineNode(Node, SourceFile) helper function.

[mhegazy]

do not think you need this change from TextRangeWithKind to Node.