[release-2.8] Combine keyof T inferences (#22525)#22708
Merged
DanielRosenwasser merged 1 commit intorelease-2.8from Mar 20, 2018
Merged
[release-2.8] Combine keyof T inferences (#22525)#22708DanielRosenwasser merged 1 commit intorelease-2.8from
DanielRosenwasser merged 1 commit intorelease-2.8from
Conversation
* Combine keyof T inferences * Extract covariant inference derivation into function * Test:keyof inference lower priority than return inference for #22376 * Update 'expected' comment in keyofInferenceLowerPriorityThanReturn * Update comment in test too, not just baselines * Fix typo * Move tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports #22525 to release-2.8
Combine keyof T inferences
Extract covariant inference derivation into function
Test:keyof inference lower priority than return inference
for #22376
Update 'expected' comment in keyofInferenceLowerPriorityThanReturn
Update comment in test too, not just baselines
Fix typo
Move tests
Fixes #