Skip to content

Add kindModifier to mark if a completion item is for an optional field #20839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2018

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Dec 21, 2017

For #12458

Adds a new KindModifier for completion items to mark when a property is optional. This can be used by editors to either change the completion item icon or add a ? to the completion item text

For microsoft#12458

Adds a new KindModifier for completion items to mark when a property is optional. This can be used by editors to either change the item icon or add a `?` to the item text
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We'll have to make a change in Visual Studio to support this.

@ghost
Copy link

ghost commented Dec 21, 2017

As for the travis error: Just run gulp runtests --t API and move files from tests/baselines/local/api to tests/baselines/reference/api.

@mhegazy mhegazy merged commit 12d5063 into microsoft:master Jan 5, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants