Skip to content

Fix devtools test #20731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2017
Merged

Fix devtools test #20731

merged 2 commits into from
Dec 18, 2017

Conversation

weswigham
Copy link
Member

#20706 Made the declaration kinds handled by getSymbolAtLocation more explicit, but didn't include Identifier, which we have no normal tests covering. It being missing caused the test to trigger an assertion. Additionally, we made a change to the lib that slightly affects the baseline file.

@DanielRosenwasser
Copy link
Member

❤️

@weswigham weswigham merged commit 6c15fc6 into microsoft:master Dec 18, 2017
@weswigham weswigham deleted the pin-devtools branch December 18, 2017 22:47
@microsoft microsoft locked and limited conversation to collaborators Jun 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants