Skip to content

Correct super() Code Fix Formatting on Single-Line Constructor #20405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

charlespierce
Copy link
Contributor

Fixes #20073

Updates Code Fix to correctly set multiline on constructor body when adding super() call.

@charlespierce charlespierce changed the title Correct super() Code Fix Formatting #20073 Correct super() Code Fix Formatting on Single-Line Constructor Dec 2, 2017
@mhegazy mhegazy requested a review from a user December 2, 2017 19:43
@mhegazy
Copy link
Contributor

mhegazy commented Dec 2, 2017

@Andy-MS can you please review and merge

@ghost
Copy link

ghost commented Dec 4, 2017

I've created #20445 which would modify ChangeTracker instead.

@ghost
Copy link

ghost commented Dec 5, 2017

Thanks for finding where the error was -- did the fix in #20445 but mostly modified ChangeTracker instead of its users.

@ghost ghost closed this Dec 5, 2017
@charlespierce charlespierce deleted the codefix_super_single_line branch December 6, 2017 04:52
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants