Recreate old decorator metadata behavior #19089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18509.
With
strictNullChecks
off, now we intentionally elideundefined
andnull
from the list of type nodes we look at when attempting to find a metadata type for a union type node (and always elidenever
), emulating our pre-2.4 behavior. As stated in the issue, the behavioral change was actually witnessable in 0eaa8eb - you can see this PR reverts the baselines changed in that commit to their original output.