Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor jsdoc types to typescript #18747

Merged
merged 19 commits into from
Oct 13, 2017
Merged

Refactor jsdoc types to typescript #18747

merged 19 commits into from
Oct 13, 2017

Commits on Sep 25, 2017

  1. Refactor JSDoc types to Typescript types 

    When the caret is on a Typescript declaration that has no type, but does
have a JSDoc annotation with a type, this refactor will add the
Typescript equivalent of the JSDoc type.

Notes:

1. This doesn't delete the JSDoc comment or delete parts of it. In fact,
due to bugs in trivia handling, it sometimes duplicates the comment.
These bugs are tracked in #18626.

2. As a bonus, when `noImplicitAny: true`, this shows up as a code fix in VS Code
whenever there is a no-implicit-any error. With `noImplicityAny: false`,
this code must be invoked via the refactoring command.
    @sandersn
    sandersn committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    6d218e2 View commit details
    Browse the repository at this point in the history

  2. Test:refactor JSDoc types to Typescript types

    @sandersn
    sandersn committed Sep 25, 2017
    Configuration menu
    Copy the full SHA
    8996d11 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2017

  1. Change refactoring name and description

    @sandersn
    sandersn committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    13b37a4 View commit details
    Browse the repository at this point in the history

  2. Move filenames to match refactoring rename

    @sandersn
    sandersn committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    96b8093 View commit details
    Browse the repository at this point in the history

  3. Transform jsdoc types in the refactor, not emitter 

    The emitter now understands JSDoc types but emits them in the original
format.
    @sandersn
    sandersn committed Sep 26, 2017
    Configuration menu
    Copy the full SHA
    fc933d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2017

  1. Merge branch 'master' into refactor-jsdoc-types-to-typescript

    @sandersn
    sandersn committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    724a813 View commit details
    Browse the repository at this point in the history

  2. Correctly transform jsdoc parameter types 

    And give a better name for rest params
    @sandersn
    sandersn committed Sep 28, 2017
    Configuration menu
    Copy the full SHA
    d797b4a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2017

  1. Merge branch 'master' into refactor-jsdoc-types-to-typescript

    @sandersn
    sandersn committed Oct 2, 2017
    Configuration menu
    Copy the full SHA
    6831e65 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2017

  1. Convert all JSDoc parameters and return types of functions

    @sandersn
    sandersn committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    4930cad View commit details
    Browse the repository at this point in the history

  2. Add and update jsdoc annotation refactoring tests

    @sandersn
    sandersn committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    1a1c1f9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into refactor-jsdoc-types-to-typescript

    @sandersn
    sandersn committed Oct 11, 2017
    Configuration menu
    Copy the full SHA
    d7424b0 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2017

  1. Merge branch 'master' into refactor-jsdoc-types-to-typescript

    @mhegazy
    mhegazy authored Oct 12, 2017
    Configuration menu
    Copy the full SHA
    260d37e View commit details
    Browse the repository at this point in the history

  2. Convert @template tag to type parameters in refactor

    @sandersn
    sandersn committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    123347d View commit details
    Browse the repository at this point in the history

  3. Test refactor of JSDoc @template tag

    @sandersn
    sandersn committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    b440d75 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into refactor-jsdoc-types-to-typescript

    @sandersn
    sandersn committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    c2c18a8 View commit details
    Browse the repository at this point in the history

  5. Fix duplicated JSDoc comments 

    Incorporate suppressLeadingAndTrailingTrivia just added by @amcasey.
    @sandersn
    sandersn committed Oct 12, 2017
    Configuration menu
    Copy the full SHA
    f35764d View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2017

  1. JSDoc->type refactor:Renames+improve never handling

    @sandersn
    sandersn committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    c83daa6 View commit details
    Browse the repository at this point in the history

  2. return more Debug.fails instead of undefined.

    @sandersn
    sandersn committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    84e3507 View commit details
    Browse the repository at this point in the history

  3. Fix spacing lint

    @sandersn
    sandersn committed Oct 13, 2017
    Configuration menu
    Copy the full SHA
    4cf06bb View commit details
    Browse the repository at this point in the history