Support JS baselines in Extract Method unit tests#18627
Closed
amcasey wants to merge 3 commits intomicrosoft:masterfrom
Closed
Support JS baselines in Extract Method unit tests#18627amcasey wants to merge 3 commits intomicrosoft:masterfrom
amcasey wants to merge 3 commits intomicrosoft:masterfrom
Conversation
Member
Author
|
FYI @paulvanbrenk |
RyanCavanaugh
approved these changes
Sep 27, 2017
Member
Author
|
I'm going to wait until #18783 is in. |
paulvanbrenk
approved these changes
Sep 27, 2017
| if (!selectionRange) { | ||
| throw new Error(`Test ${caption} does not specify selection range`); | ||
| } | ||
| function testExtractMethod(caption: string, extensions: Extension[], text: string) { |
Contributor
There was a problem hiding this comment.
make extension default to .ts?
Member
Author
|
Decided on a more automated approach. See #18829. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I basically just eyeballed the existing tests and picked the ones that looked like JS.
Note that we could actually get JS baselines for the other tests too, but I didn't see much benefit to doing so.