Optimize array operations to reduce memory footprint#18153
Merged
ahejlsberg merged 1 commit intomasterfrom Sep 7, 2017
Merged
Conversation
mhegazy
approved these changes
Sep 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we optimize array operations in the parser and binder to reduce overall memory consumption of syntax trees and binding information. Specifically, since arrays are often constructed by starting with an empty array and repeatedly calling
push(), arrays may not have an optimal memory layout. We now invokeslice()for small arrays (1 to 4 elements) to give the VM a chance to allocate an optimal representation.These optimizations reduce the overall size of syntax trees and binding information by ~10%. For example, memory consumption of the syntax trees and binding information for the Monaco project is reduced from 162 Mb to 145 Mb.